# HG changeset patch # User Evgeniy.Koshkin@unit-519.Labs.IntelliJ.Net # Date 1463589003 -10800 # Node ID d34412e9d54e42d9c6312d4f9aca19d228e22a0b # Parent 548a2737cc07999202b90bf58c150db6eba4c22e cleanup code after merge diff -r 548a2737cc07 -r d34412e9d54e agent/src/META-INF/build-agent-plugin-symbol-server.xml --- a/agent/src/META-INF/build-agent-plugin-symbol-server.xml Wed May 18 19:28:26 2016 +0300 +++ b/agent/src/META-INF/build-agent-plugin-symbol-server.xml Wed May 18 19:30:03 2016 +0300 @@ -8,6 +8,5 @@ - \ No newline at end of file diff -r 548a2737cc07 -r d34412e9d54e agent/src/jetbrains/buildServer/symbols/ArtifactPathHelper.java --- a/agent/src/jetbrains/buildServer/symbols/ArtifactPathHelper.java Wed May 18 19:28:26 2016 +0300 +++ b/agent/src/jetbrains/buildServer/symbols/ArtifactPathHelper.java Wed May 18 19:30:03 2016 +0300 @@ -1,11 +1,7 @@ package jetbrains.buildServer.symbols; -import jetbrains.buildServer.ExtensionHolder; -import jetbrains.buildServer.agent.impl.artifacts.ArchivePreprocessor; import jetbrains.buildServer.util.ArchiveType; import jetbrains.buildServer.util.ArchiveUtil; -import jetbrains.buildServer.util.CollectionsUtil; -import jetbrains.buildServer.util.filters.Filter; import org.jetbrains.annotations.NotNull; /** @@ -16,20 +12,14 @@ private static final String ARCHIVE_PATH_SEPARATOR_FULL = "!/"; private static final String FOLDER_SEPARATOR = "/"; - private final ExtensionHolder myExtensions; - - public ArtifactPathHelper(@NotNull final ExtensionHolder extensions) { - myExtensions = extensions; - } - @NotNull - String concatenateArtifactPath(String fileNamePrefix, String pdbFileName) { + static String concatenateArtifactPath(String fileNamePrefix, String pdbFileName) { final String normilizedFileNamePrefix = fileNamePrefix.replace(ARCHIVE_PATH_SEPARATOR, ARCHIVE_PATH_SEPARATOR_FULL); final String delimiter = (isPathToArchive(normilizedFileNamePrefix) && !normilizedFileNamePrefix.contains(ARCHIVE_PATH_SEPARATOR)) ? ARCHIVE_PATH_SEPARATOR_FULL : FOLDER_SEPARATOR; return normilizedFileNamePrefix + delimiter + pdbFileName; } - private boolean isPathToArchive(@NotNull final String path){ + static private boolean isPathToArchive(@NotNull final String path){ return ArchiveUtil.getArchiveType(path) != ArchiveType.NOT_ARCHIVE; } } diff -r 548a2737cc07 -r d34412e9d54e agent/src/jetbrains/buildServer/symbols/SymbolsIndexer.java --- a/agent/src/jetbrains/buildServer/symbols/SymbolsIndexer.java Wed May 18 19:28:26 2016 +0300 +++ b/agent/src/jetbrains/buildServer/symbols/SymbolsIndexer.java Wed May 18 19:30:03 2016 +0300 @@ -32,7 +32,6 @@ private static final String X86_SRCSRV = "\\x86\\srcsrv"; @NotNull private final ArtifactsWatcher myArtifactsWatcher; - @NotNull private final ArtifactPathHelper myArtifactPathHelper; @NotNull private final JetSymbolsExe myJetSymbolsExe; @NotNull private final Map myFileToArtifactMapToProcess = new ConcurrentHashMap(); @@ -44,11 +43,9 @@ public SymbolsIndexer(@NotNull final PluginDescriptor pluginDescriptor, @NotNull final EventDispatcher agentDispatcher, - @NotNull final ArtifactsWatcher artifactsWatcher, - @NotNull final ArtifactPathHelper artifactPathHelper) { + @NotNull final ArtifactsWatcher artifactsWatcher) { myArtifactsWatcher = artifactsWatcher; myJetSymbolsExe = new JetSymbolsExe(new File(pluginDescriptor.getPluginRoot(), "bin")); - myArtifactPathHelper = artifactPathHelper; agentDispatcher.addListener(new AgentLifeCycleAdapter() { @Override @@ -132,7 +129,7 @@ try { myProgressLogger.message("Indexing sources appeared in file " + pdbFile.getAbsolutePath()); pdbFilePatcher.patch(pdbFile, myProgressLogger); - myFileToArtifactMapToProcess.put(pdbFile, myArtifactPathHelper.concatenateArtifactPath(pdbFiles.get(pdbFile), pdbFile.getName())); + myFileToArtifactMapToProcess.put(pdbFile, ArtifactPathHelper.concatenateArtifactPath(pdbFiles.get(pdbFile), pdbFile.getName())); } catch (Throwable e) { LOG.error("Error occurred while patching symbols file " + pdbFile, e); myProgressLogger.error("Error occurred while patching symbols file " + pdbFile);