Mercurial > hg > tc-symbol-server
changeset 80:55773aa610f8 8.1.x
fixed TW-35368
author | Evgeniy.Koshkin |
---|---|
date | Tue, 23 Dec 2014 22:01:49 +0300 |
parents | f86ebe99ad25 |
children | 384401f7fc24 5c446c3a8cd3 |
files | server/src/jetbrains/buildServer/symbols/AuthHelper.java server/src/jetbrains/buildServer/symbols/DownloadSymbolsController.java |
diffstat | 2 files changed, 2 insertions(+), 9 deletions(-) [+] |
line wrap: on
line diff
--- a/server/src/jetbrains/buildServer/symbols/AuthHelper.java Tue Dec 23 20:25:18 2014 +0300 +++ b/server/src/jetbrains/buildServer/symbols/AuthHelper.java Tue Dec 23 22:01:49 2014 +0300 @@ -79,6 +79,7 @@ return user; } LOG.warn(String.format("Located user (name %s) has NO permissions to process the request.", name)); + response.sendError(HttpServletResponse.SC_FORBIDDEN, "Access denied"); return null; } }
--- a/server/src/jetbrains/buildServer/symbols/DownloadSymbolsController.java Tue Dec 23 20:25:18 2014 +0300 +++ b/server/src/jetbrains/buildServer/symbols/DownloadSymbolsController.java Tue Dec 23 22:01:49 2014 +0300 @@ -23,7 +23,6 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import java.io.BufferedOutputStream; -import java.io.IOException; import java.io.InputStream; import java.util.Iterator; import java.util.Map; @@ -97,14 +96,7 @@ final SUser user = myAuthHelper.getAuthenticatedUser(request, response, new Predicate<SUser>() { public boolean apply(SUser user) { - try{ - boolean hasPermissions = user.isPermissionGrantedForProject(projectId, Permission.VIEW_BUILD_RUNTIME_DATA); - if(!hasPermissions) response.sendError(HttpServletResponse.SC_FORBIDDEN, String.format("You have no access to PDB files in the project with id %s.", projectId)); - return hasPermissions; - } catch (IOException e) { - LOG.debug(e); - return false; - } + return user.isPermissionGrantedForProject(projectId, Permission.VIEW_BUILD_RUNTIME_DATA); } }); if (user == null) return null;