changeset 53:addde7b9aff6

improve logging while searching related project for the requested symbol
author Evgeniy.Koshkin
date Thu, 14 Nov 2013 17:18:41 +0400
parents f4a7cca29e5f
children 3c889ef68a6f
files server/src/jetbrains/buildServer/symbols/DownloadSymbolsController.java
diffstat 1 files changed, 10 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/server/src/jetbrains/buildServer/symbols/DownloadSymbolsController.java	Thu Nov 14 13:54:19 2013 +0400
+++ b/server/src/jetbrains/buildServer/symbols/DownloadSymbolsController.java	Thu Nov 14 17:18:41 2013 +0400
@@ -167,11 +167,17 @@
 
   @Nullable
   private String findRelatedProjectId(String symbolFileId) {
-    //TODO: log errorS
     final BuildMetadataEntry metadataEntry = getMetadataEntry(symbolFileId);
-    if(metadataEntry == null) return null;
-    final SBuild build = myServer.findBuildInstanceById(metadataEntry.getBuildId());
-    if(build == null) return null;
+    if(metadataEntry == null) {
+      LOG.debug(String.format("There is no information about symbol file with id %s in the index.", symbolFileId));
+      return null;
+    }
+    long buildId = metadataEntry.getBuildId();
+    final SBuild build = myServer.findBuildInstanceById(buildId);
+    if(build == null) {
+      LOG.debug(String.format("Failed to find build by id %d. Requested symbol file with id %s expected to be produced by that build.", buildId, symbolFileId));
+      return null;
+    }
     return build.getProjectId();
   }